Skip to content

Conversation

notriddle
Copy link
Contributor

No description provided.

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Oct 17, 2022
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @CraftSpider (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot
Copy link
Collaborator

rustbot commented Oct 17, 2022

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 17, 2022
@rust-log-analyzer

This comment has been minimized.

@notriddle notriddle force-pushed the notriddle/sub-logo-container branch 2 times, most recently from 1028753 to 7de1b37 Compare October 17, 2022 00:25
@rust-log-analyzer

This comment has been minimized.

* Since it's used exclusively on source pages, no need to explicitly
  select.

* No need to hide it when the sidebar is open, since it fills the whole
  page.
@notriddle notriddle force-pushed the notriddle/sub-logo-container branch from 7de1b37 to bcf4cfe Compare October 17, 2022 00:57
@GuillaumeGomez
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 17, 2022

📌 Commit bcf4cfe has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 17, 2022
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#102962 (remote-test-server: Show command line arguments)
 - rust-lang#103129 (rustdoc: remove unused `.sub-logo-container` DOM on non-source pages)
 - rust-lang#103136 (Fix types in documentation for `Alignment::as_usize` and `Alignmnet::as_nonzero`)
 - rust-lang#103139 (Duplicate comment in mod.rs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 81ea72b into rust-lang:master Oct 17, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 17, 2022
@notriddle notriddle deleted the notriddle/sub-logo-container branch October 17, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants